-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAAPI: add support for protected audience extensions and "direct" buyers (igb
)
#11277
Conversation
ext.igi
igb
) support
igb
) support igb
)
92a75a0
to
4001b60
Compare
Summary of PMC feedback:
|
Shouldn't this be |
Yes. It looks like I used the right field in code but not the description. |
@jlquaccia please review the PR |
deepSetValue(bidReq, 'ortb2Imp.ext.ae', bidAe); | ||
bidReq.ortb2Imp.ext.igs = Object.assign({ | ||
ae: bidAe, | ||
biddable: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed on https://github.com/InteractiveAdvertisingBureau/openrtb/blob/main/extensions/community_extensions/Protected%20Audience%20Support.md, it states that the biddable field is 0 by default (indicating a buyer is not allowed). Also saw in the prebid "fledge" slack channel (about a month back) that the biddable field default may get reversed to 1 instead. Is there an update on the latest around this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK there's no concrete plan for the spec to change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this default in the spec a strange choice as well, however, Prebid can default to a different value than a dsp should interpret a result with a missing value. A dsp should consider biddable null as non-biddable, we'll always pass 1, bc we consider these requests worthwhile. What a dsp should consider biddable null to mean doesn't impact what field we should choose to pass.
…ers (`igb`) (prebid#11277) * set ortb2Imp.ext.igs * PAAPI: add ortbConverter support for request ext.igi and response ext.igi.igs * Update paapi hook to accept auction config as one field * mergeBuyers * partitionBuyers * add fpd to perBuyerSignals * complete igb treatment * improve names * parse ext.igi.igb * naming improvement * update debugging mod to work with igb * fix mergeBuyers to work with actual URL origins * rename componentBuyers to componentSeller * signal componentSeller config to bid adapters
Type of change
Description of change
This adds support for the ORTB protected audience extensions:
ortb2Imp.ext.igs
is populated (similar and in addition toext.ae
)igb
) objects in additon to auction configs (config
). ThefledgeAuctionConfigs
response property is migrated topaapi
. for example:ext.igi
to generate apaapi
array.paapi.componentSeller.auctionConfig
is set, we attempt to collect all IGB objects into a single auction config, which is then treated like any other auction config for the purpose ofgetPAAPIConfig/setPAAPIConfigForGPT
.ortb2
/ortb2Imp
) can vary by adapter, auction configs generated from IGB have it set inperBuyerSignals
instead ofauctionSignals
. "Normal" auction configs also have first party data repeated inperBuyerSignals
, for consistency.auctionSignals
is populated with first party data as usual.Other information
Closes #11131
Closes #11094